Goutam/lynkeduppro-crm
2
1
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(auth): complete Google OAuth after SDK boot #3

Merged
tanweer919 merged 1 commits from feat/login-methods into goutamnextflow 2026-07-12 20:01:53 +00:00
Conversation 0 Commits 1 Files Changed 1
+15 -3
tanweer919 commented 2026-07-12 20:01:42 +00:00
Collaborator
Copy Link
Copy Source

OAuth-return effect ran before boot; gate on ready so completeOAuthLogin actually exchanges the code. Fixes stuck-on-?code=#identify.

OAuth-return effect ran before boot; gate on ready so completeOAuthLogin actually exchanges the code. Fixes stuck-on-?code=#identify.
tanweer919 added 1 commit 2026-07-12 20:01:43 +00:00
fix(auth): complete Google OAuth after SDK boot (was stuck on ?code=…#identify) 6e1a895e7e 
The OAuth-return effect ran on mount before AppShell finished booting, so
completeOAuthLogin no-oped (sdk.auth undefined → null) and fell back to identify,
never retrying. Gate it on useAppShell().ready so it runs once auth is up, and
strip ?code= from the URL on success.
tanweer919 merged commit 6d0c8890d3 into goutamnextflow 2026-07-12 20:01:53 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Mayur7887 (Mayur Shinde) abhinav (Abhinav Kapoor) maaz519 (Maaz Ahamed) tanweer919 (Tanweer Anwar) Goutam (Goutam Patidar)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Goutam/lynkeduppro-crm#3
Delete Branch "feat/login-methods"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?